Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store cursor position when changing lines #749

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Store cursor position when changing lines #749

merged 2 commits into from
Apr 12, 2024

Conversation

jamesreprise
Copy link
Contributor

What is the goal of this PR?

We store cursor positions when changing lines as described in #748. This is standard behaviour in other IDEs, such as IntelliJ IDEA and VSCode.

Before:

Screen.Recording.2023-06-18.at.17.22.44.mov

After:

Screen.Recording.2023-06-18.at.17.21.25.mov

What are the changes implemented in this PR?

We store an additional piece of data in Cursor, lastCol. This remembers the last position of the column, which we only forget upon the creation of a new cursor by a method other than moving up or down a line.

Additional info

Closes #748

@jamesreprise jamesreprise self-assigned this Jun 18, 2023
@typedb-bot
Copy link
Member

typedb-bot commented Jun 18, 2023 •
edited by alexjpwalker
Loading

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@jamesreprise jamesreprise marked this pull request as ready for review November 30, 2023 10:19
@jamesreprise jamesreprise force-pushed the store-cursor-position branch from 1d6b4c8 to 54517d7 Compare April 11, 2024 15:43
alexjpwalker
alexjpwalker approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@alexjpwalker alexjpwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@jamesreprise jamesreprise merged commit 1345227 into typedb:development Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjpwalker alexjpwalker alexjpwalker approved these changes

@flyingsilverfin flyingsilverfin Awaiting requested review from flyingsilverfin flyingsilverfin is a code owner

Assignees

@flyingsilverfin flyingsilverfin

@alexjpwalker alexjpwalker

@jamesreprise jamesreprise

Labels
domain: text-editor priority: medium type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor position is not stored when changing lines
4 participants
@jamesreprise @typedb-bot @alexjpwalker @flyingsilverfin